Improve all websites dashboard performance when using range date #9992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
Very good find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9662
Tested it locally with 1000 sites and reduced time to generate report from 60 seconds to about 4 seconds (with profiling enabled). Problem was it called millions of times (3 periods * 1000 sites * 1000 sites) all segments etc. as there was a bug when getting the string for the done flag.
For each of those 1000 sites we called again 1000 times getDoneString... which results in 1mio calls for each period. When user has 2000 sites it was likely 12 mio calls. Now it should call it only a few thousand times.