Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New automated test to detect when piwik.js minified file is out of sync with original piwik.js #9983

Merged
merged 1 commit into from Mar 31, 2016
Merged

New automated test to detect when piwik.js minified file is out of sync with original piwik.js #9983

merged 1 commit into from Mar 31, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Mar 30, 2016

fixes #8195

edit: tests fail on travis (works locally), not sure yet why

@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 30, 2016
@mattab mattab added this to the 2.16.1 milestone Mar 30, 2016
@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Mar 30, 2016
@mattab
Copy link
Member Author

mattab commented Mar 31, 2016

FYI Build is now green

@mattab mattab removed the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Mar 31, 2016
@mattab
Copy link
Member Author

mattab commented Mar 31, 2016

I'm merging now to get the up to date minified piwik.js - if you have feedback post merge i'll be happy to apply of course!

@mattab mattab merged commit 6385b5a into master Mar 31, 2016
@mattab mattab deleted the 8195 branch March 31, 2016 05:12
sgiehl
sgiehl reviewed Mar 31, 2016
View reviewed changes
tests/PHPUnit/Integration/ReleaseCheckListTest.php

$piwikJsMinifiedInGit = file_get_contents(PIWIK_DOCUMENT_ROOT . '/piwik.js');

$this->assertEquals($piwikJsMinified, $piwikJsMinifiedInGit, 'piwik.js minified is out of date - please re-generate the piwik.js. See instructions in js/README');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't you using assertFileEquals? that would do the file_get_contents automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good trick! done in c881db2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattab @sgiehl