@mattab opened this Issue on March 30th 2016 Member

In #9674 we're adding an integration test to check that all currently supported IANA.ORG domain extensions are considered valid by Piwik. This test downloads the list of all domain extensions from: http://data.iana.org/TLD/tlds-alpha-by-domain.txt


When IANA.ORG adds new domain extensions in this list, our test will start failing, because our Email validator code does not yet handle the new extension... Our email validator has all supported extensions hardcoded in the file libs/Zend/Validate/Hostname.php

From one day to the next, our build can start failing with the error:

1) Piwik\Tests\Integration\EmailValidatorTest::test_allCurrentTlds
Failed asserting that false is true.

(source: https://travis-ci.org/piwik/piwik/jobs/119366743 )

How do we fix this issue?

@mattab commented on March 30th 2016 Member

fyi: for now I've just fixed the integration test by manually adding the new TLD extension in https://github.com/piwik/piwik/commit/951dbcba07571b9864e34626f57729bc6b0af154

@mattab commented on April 27th 2016 Member

From now on the test will fail when at least 5 new domains were added as a way to minimise number of times this test starts failing https://github.com/piwik/piwik/commit/4aee468dea66ef518da096549bb86fe9d9e89fb7 - not ideal, maybe you have a better idea?

Powered by GitHub Issue Mirror