Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated SQL mode #9970

Closed
johannes opened this issue Mar 29, 2016 · 3 comments
Closed

Deprecated SQL mode #9970

johannes opened this issue Mar 29, 2016 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@johannes
Copy link

Piwik sets a deprecated SQL Mode for MySQL:

$ grep -rn SQL_MODE . 2>/dev/null
./core/Db/Adapter/Mysqli.php:61:        $this->_connection->query('SET sql_mode = "' . Db::SQL_MODE . '"');
./core/Db/Adapter/Pdo/Mysql.php:79:        $this->_connection->exec('SET sql_mode = "' . Db::SQL_MODE . '"');
./core/Db.php:36:    const SQL_MODE = 'NO_AUTO_VALUE_ON_ZERO';

mysql> SET sql_mode = "NO_AUTO_VALUE_ON_ZERO";
Query OK, 0 rows affected, 1 warning (0.00 sec)

mysql> show warnings;
+---------+------+------------------------------------------------------------------------------------------------+
| Level   | Code | Message                                                                                        |
+---------+------+------------------------------------------------------------------------------------------------+
| Warning | 3090 | Changing sql mode 'NO_AUTO_CREATE_USER' is deprecated. It will be removed in a future release. |
+---------+------+------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

The way this is set this also disables other default values. In 5.7 the default is ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
@johannes johannes mentioned this issue Mar 29, 2016
Open
@tsteur
Copy link
Member

tsteur commented Mar 29, 2016

I presume this would mean we need to set NO_AUTO_CREATE_USER in case it is a supported mode as we currently support 4.1+ and this mode was introduced in 5.7 from my understanding. Maybe we better let users customize the SQL mode in config? This could introduce some regressions eg when a user configures ONLY_FULL_GROUP_BY but we could remove some modes from the configured list where we know Piwik is not compatible with (eg ONLY_FULL_GROUP_BY).

Also to be considered that this mode will be removed again at some point. From http://dev.mysql.com/doc/refman/5.7/en/sql-mode.html

NO_AUTO_CREATE_USER will be removed in a future MySQL release, at which point its effect will be enabled at all times (GRANT will not create accounts).

Grüße :)

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 29, 2016
@johannes
Copy link
Author

Actually I haven't looked deeper into this - was looking at other errors on the server and noticed the piwik related notices :)

I don't think the user should configure this. This will likely break the application (i.e. ANSI_QUOTES, IGNORE_SPACE, NO_BACKSLASH_ESCAPES can easily break SQL working on some machines in subtle ways) Setting things like ONLY_FULL_GROUP_BY is useful to ensure that you select daa you actually want to retrieve. Without full group by it is possible to retrieve "random" data.

Do you really have a use case to support MySQL 4.1? - 4.1 is out of support in upstream since end of 2008. Even 5.1 is ten years old.

@mattab
Copy link
Member

mattab commented Mar 31, 2016

Thanks for the report. In this case, since the MySQL setting will be removed later, I suggest we ignore this warning for now.

Do you really have a use case to support MySQL 4.1? - 4.1 is out of support in upstream since end of 2008. Even 5.1 is ten years old.

We don't anymore: next major version of Piwik will require MySQL 5.5: #9107

@mattab mattab closed this as completed Mar 31, 2016
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johannes @tsteur @mattab