Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide widget when not found (goals, custom dimensions, custom reports) #9969

Closed
piwikbugs opened this issue Mar 28, 2016 · 7 comments · Fixed by #20007
Closed

Hide widget when not found (goals, custom dimensions, custom reports) #9969

piwikbugs opened this issue Mar 28, 2016 · 7 comments · Fixed by #20007
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@piwikbugs
Copy link

I track multiple websites with Piwik. If I add some goals to my dashboard in Website A (Dashboard -> add a widget -> goals), and then change to Website B, it shows the widgets I just added to Website A as "Widgets not found" on Website B dashboard.

Do I have to make a NEW dashboard with every website?

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 29, 2016
@tsteur
Copy link
Member

tsteur commented Mar 29, 2016

@piwikbugs thank you for creating the issue. This is a bug. I'm not sure if we already have an issue for this but I could not find one. It won't be trivial to solve. It's almost like the dashboard needs to have knowledge which widgets depend on a idSite or something.

I think, when two different websites have the same goalId, it will even show different goals although one might be not interested of that goal.

@mattab
Copy link
Member

mattab commented Mar 31, 2016

fyi: there is a similar issue if you have a "Custom Dimension" widget, and after changing the website we get an error message in the widget: "Custom dimension XYZ does not exist for this website".

pinging @sgiehl - maybe you could help with this one.

@mattab mattab modified the milestones: 2.16.x (LTS), Mid term Mar 31, 2016
@piwikbugs
Copy link
Author

Unfortunately this isn't resolved yet. Also when I have for example 4 Goal widgets added on the dashboard of website A, all 4 are shown at website B, even if I only have one goal for website B.

@mattab mattab modified the milestones: 2.16.x (LTS), Mid term May 27, 2016
@mattab
Copy link
Member

mattab commented Jul 18, 2016

Ideally, we will hide the widgets that do not apply to a given website, without updating the layout stored in the DB, so that people still find the dashboard layout they expect on each website.

@mattab mattab modified the milestones: 2.16.x (LTS), Mid term Aug 25, 2016
@mattab mattab changed the title Widget not found (goals) Widget not found (goals, custom dimensions, custom reports) Dec 23, 2019
@mattab mattab removed this from the Backlog (Help wanted) milestone Dec 23, 2019
@mattab
Copy link
Member

mattab commented Dec 23, 2019

Same problem for "Custom reports" as well (updated issue title).

Reported by a customer today:

We have several websites set up and many of these have custom reports set up.
Each custom report is specific for the website of course.
Now when I want to create a dashboard for a specific website the dashboard is automatically created for ALL websites.
This is an issue as custom reports available for website A are not available for website B and vice versa. Please see below image where widget 'Lobby Visits' is available for one site but for another it is not.
The custom reports 'Lobby Visits' exists for both sites - but they are set up separately as different settings/segments are needed for each website.
When creating a segment we have the option to select 'only this website' or 'all'.

· Would it be possible to add something similar for dashboards?

Thank you very much.

@mattab mattab added this to the 4.2.0 milestone Jan 9, 2020
@tsteur tsteur modified the milestones: 4.5.0, 4.7.0 Jul 22, 2021
@tsteur tsteur modified the milestones: 4.8.0, 4.9.0 Feb 9, 2022
@tsteur tsteur modified the milestones: 4.9.0, 4.10.0 Mar 2, 2022
@sgiehl
Copy link
Member

sgiehl commented Apr 4, 2022

This one might actually not be that easy to solve, as it's hard to define the expected behavior.
We can for sure simply give unavailable widgets a display: none, so they are hidden.
But how shall we handle widgets that would be hidden on all sites. Like a removed goal or custom report. If they were hidden on all dashboard they would remain there hidden, until they get valid again. This could cause a lot hidden widgets on dashboard that never get removed.
Also it's hard to handle adding new widgets in that case. When a widget is placed in the same row as a hidden widget, the user can't se if he is placing the widget above or below. There might be more problems that could occur.

I guess a better solution would be to introduce site specific dashboards like proposed in #18467
Dashboards could then be made site specific as soon as a site specific widget is added.

@tsteur
Copy link
Member

tsteur commented May 8, 2022

As we likely won't have #18467 any time soon and it meanwhile looks very buggy to have this "Widget not found" issue, the easiest would be to just hide these widgets when they weren't found. This could be implemented very quickly and be a massive improvement. I ran myself into this issue just before again thinking Matomo is buggy.

@mattab mattab modified the milestones: Priority Backlog (Help wanted), 4.12.5, 4.12.4 Nov 13, 2022
@peterhashair peterhashair self-assigned this Nov 14, 2022
@elabuwa elabuwa changed the title Widget not found (goals, custom dimensions, custom reports) Hide widget when not found (goals, custom dimensions, custom reports) Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants