@sgiehl opened this Pull Request on March 20th 2016 Member

Moving all logic from the separate PivotBy viz to the HtmlTable viz solves the problem.

fixes #9667

might also be a solution for #9716

@tsteur commented on March 29th 2016 Member

Have you seen the 2 failing UI tests? http://builds-artifacts.piwik.org/piwik/piwik/pivot_9667/18398/PivotByDimension_pivoted_columns_report and http://builds-artifacts.piwik.org/piwik/piwik/pivot_9667/18398/PivotByDimension_pivoted ? I tried to find a CSS selector that matches pivotby dataTable but couldn't really find anything but there are now some CSS classes matching like dataTableVizHtmlTable etc. I presume we can still merge and it is expected. :+1:

@sgiehl commented on March 29th 2016 Member

@tsteur Yes, the small changes in the UI tests are because the css class of the datatable changed. But it is somehow expected.

@mattab commented on March 30th 2016 Member

Good find @sgiehl ! :+1:

This Pull Request was closed on March 29th 2016
Powered by GitHub Issue Mirror