Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik.js 'setDomains' method supports page wildcards matching: example.com/index* #9934

Closed

Conversation

mattab
Copy link
Member

@mattab mattab commented Mar 16, 2016

Based on another PR to merge first: #9933

setDomains("example.com/index*") will correctly not track an outlink request for example.com/index.html or example.com/index_en.html

refs #9932

…okie path.

Instead, we will better document how to correctly set the cookie configuration. #9932
@mattab mattab added the Needs Review PRs that need a code review label Mar 16, 2016
@mattab mattab added this to the 2.16.1 milestone Mar 16, 2016
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Mar 16, 2016
@mattab
Copy link
Member Author

mattab commented Mar 16, 2016

@tsteur
Copy link
Member

tsteur commented Mar 29, 2016

LGTM. Maybe we should add this new feature to the developer changelog?

Also I cannot merge it probably because of a conflict with piwik.js maybe. I could resolve that later.

 setDomains("example.com/index*") will correcrly not track an outlink request for example.com/index.html
 refs #9932

New unit tests and actually making the code work per spec
@mattab
Copy link
Member Author

mattab commented Mar 30, 2016

merged in #9979

@mattab mattab deleted the piwikjs_support_wildcards_setDomains branch April 7, 2016 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants