piwik.js: remove the feature of setDomains that sets cookie path
#9933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
changed the title
setDomains magically setting the cookie pathsetDomains that sets cookie path
|
@mattab I pushed compiled piwik.js . Feel free to merge. Should it be in changelog? |
…okie path. Instead, we will better document how to correctly set the cookie configuration. #9932
mattab
force-pushed
the
remove_magic_setCookiePath
branch
from
dde4c6a
to
3ff659d
Compare
mattab
pushed a commit
that referenced
this pull request
Mar 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we will better document how to correctly set the cookie configuration.
Todo
Refs #9932