Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better document how to measure Domains, Sub-domains, or a mix of both, and how to correctly configure the JavaScript tracker with setDomains, setCookieDomain and setCookiePath #9932

Closed
9 tasks done
mattab opened this issue Mar 16, 2016 · 3 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Mar 16, 2016

@mattab mattab added this to the 2.16.1 milestone Mar 16, 2016
mattab added a commit that referenced this issue Mar 16, 2016
…okie path.

Instead, we will better document how to correctly set the cookie configuration. #9932
@mattab
Copy link
Member Author

mattab commented Mar 16, 2016

When setDomains is used, let's remove the magic functionality to automatically set the cookie path

PR: #9933

@mattab
Copy link
Member Author

mattab commented Mar 16, 2016

can I use setCookieDomain with url such as example.com/subdirectory ?

Idea: to simplify our JS API, maybe we could

  • deprecate setCookiePath (and remove from docs)
  • let user to use setCookieDomain and improve this function so it also works with path

Remove this API function would make understanding things slightly easier.

Created #9980

mattab pushed a commit to matomo-org/developer-documentation that referenced this issue Mar 16, 2016
mattab added a commit that referenced this issue Mar 16, 2016
 setDomains("example.com/index*") will correcrly not track an outlink request for example.com/index.html
 refs #9932
mattab added a commit that referenced this issue Mar 30, 2016
 setDomains("example.com/index*") will correcrly not track an outlink request for example.com/index.html
 refs #9932

New unit tests and actually making the code work per spec
mattab added a commit that referenced this issue Mar 30, 2016
…okie path.

Instead, we will better document how to correctly set the cookie configuration. #9932
mattab added a commit that referenced this issue Mar 30, 2016
…e.com/index*

`setDomains("example.com/index*")` will correctly not track an outlink request to for example.com/index.html or example.com/index_en.html

refs #9932
mattab added a commit that referenced this issue Mar 30, 2016
@mattab
Copy link
Member Author

mattab commented Mar 30, 2016

All sub tasks done.

@mattab mattab closed this as completed Mar 30, 2016
@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

1 participant