Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes various z-index issues #9917

Merged
merged 3 commits into from Mar 15, 2016
Merged

Fixes various z-index issues #9917

merged 3 commits into from Mar 15, 2016

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 12, 2016

  • site selector should be behind popover background
  • site selector should be behind metric tooltips
  • check & improve tests

fixes #9868

@sgiehl sgiehl added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Mar 12, 2016
@sgiehl sgiehl self-assigned this Mar 12, 2016
@sgiehl sgiehl added this to the 2.16.1 milestone Mar 12, 2016
@sgiehl sgiehl force-pushed the zindex branch 11 times, most recently from b79374a to 56955ac Compare March 14, 2016 22:04
@sgiehl sgiehl added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Mar 14, 2016
@sgiehl sgiehl removed their assignment Mar 14, 2016
mattab pushed a commit that referenced this pull request Mar 15, 2016
Merge pull request #9917 from piwik/zindex
121dd99 
Fixes various z-index issues
@mattab mattab merged commit 121dd99 into master Mar 15, 2016
@mattab mattab deleted the zindex branch March 15, 2016 00:15
@mattab
Copy link
Member

mattab commented Mar 15, 2016

Interestingly, we had a UI test showing the regression but did not spot it http://builds-artifacts.piwik.org/piwik/piwik/master/18338/UsersManager_adminuser_all_users_confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab