Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB field name Screen resolution is too small: width and height should not be limited to 9999 pixels #9913

Closed
mattab opened this issue Mar 10, 2016 · 1 comment · Fixed by #10489
Closed

DB field name Screen resolution is too small: width and height should not be limited to 9999 pixels #9913

mattab opened this issue Mar 10, 2016 · 1 comment · Fixed by #10489
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.0.0-b1

Comments

@mattab
Copy link
Member

mattab commented Mar 10, 2016

The current resolution field is set to VARCHAR(9). This means that the field may be truncated if we store a resolution width or height more than 9999 pixels. Then the resolution wouldn't fit in 9 characters (they are stored separated by a x in log_visit.config_resolution).

Goal of this issue is to change the DB field type to allow for more characters, so one could track very large resolutions. (note that the integration test in RequestTest.php (and getResolution in Tracker/Request) will need to be updated, see https://github.com/piwik/piwik/pull/9914/files#diff-35f2659319670251c767de1da7cb514aR358)

follows up #9911
@mattab mattab added this to the 3.0.0-b1 milestone Mar 10, 2016
@tsteur
Copy link
Member

tsteur commented Mar 10, 2016

👍

@tsteur tsteur mentioned this issue Mar 10, 2016
Closed
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 13, 2016
@tsteur tsteur self-assigned this Sep 13, 2016
tsteur added a commit that referenced this issue Sep 13, 2016
@tsteur
fixes #9913 make resolution field bigger
f659e32
@tsteur tsteur mentioned this issue Sep 13, 2016
Merged
tsteur added a commit that referenced this issue Sep 13, 2016
@tsteur
Make resolution field bigger (#10489)
e46a532 
* fixes #9913 make resolution field bigger

* fix ui test
@tsteur tsteur closed this as completed Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging a pull request may close this issue.

Make resolution field bigger matomo-org/matomo
2 participants
@tsteur @mattab