Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen resolutions may appear with decimal such as 1279.5652 and may be truncated #9911

Closed
mattab opened this issue Mar 10, 2016 · 3 comments
Closed

Screen resolutions may appear with decimal such as 1279.5652 and may be truncated #9911

mattab opened this issue Mar 10, 2016 · 3 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone
2.16.x (LTS)

Comments

@mattab
Copy link
Member

mattab commented Mar 10, 2016

Reported in: https://forum.piwik.org/t/broken-screen-resolution-data/16073

Some screen resolutions appear with decimal and are truncated.

Firefox
Mac 10.8
Resolution1440.0000

Chrome
Windows 7
Resolution1848.0000

Firefox
Windows XP
Resolution1279.5652

Expected:

  • the resolution width or height should not be a decimal number but rounded.
  • the resolution should not be truncated.
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 10, 2016
@mattab mattab added this to the 2.16.1 milestone Mar 10, 2016
@mattab mattab changed the title Screen resolutions may appear with decimal such as Screen resolutions may appear with decimal such as 1440.0000 and may be truncated Mar 10, 2016
@mattab mattab changed the title Screen resolutions may appear with decimal such as 1440.0000 and may be truncated Screen resolutions may appear with decimal such as 1279.5652 and may be truncated Mar 10, 2016
This was referenced Mar 10, 2016
Closed
Closed
@mattab mattab self-assigned this Mar 10, 2016
@mattab mattab mentioned this issue Mar 10, 2016
Closed
@mattab mattab mentioned this issue Mar 10, 2016
Closed
@mattab
Copy link
Member Author

mattab commented Mar 10, 2016

PR: https://github.com/piwik/piwik/pull/9914/files

mattab added a commit that referenced this issue Mar 10, 2016
@mattab
Screen resolution should be tracked correctly
546bac0 
fixes #9911
@tsteur
Copy link
Member

tsteur commented Mar 10, 2016

The issue was already solved and they only need to update to Piwik 2.16.0

@mattab mattab modified the milestones: 2.16.x (LTS), 2.16.1 Mar 15, 2016
@mattab
Copy link
Member Author

mattab commented Mar 15, 2016

It was already fixed in piwik.js in https://github.com/piwik/piwik/pull/9388/files

@mattab mattab closed this as completed Mar 15, 2016
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
2.16.x (LTS)
Development

No branches or pull requests
2 participants
@tsteur @mattab