Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name for our new Piwik 2 and 3 develop branches (feedback needed quickly) #9891

Closed
tsteur opened this issue Mar 8, 2016 · 5 comments
Closed

Name for our new Piwik 2 and 3 develop branches (feedback needed quickly) #9891

tsteur opened this issue Mar 8, 2016 · 5 comments
Labels
RFC Indicates the issue is a request for comments where the author is looking for feedback.
Milestone
2.16.1

Comments

@tsteur
Copy link
Member

tsteur commented Mar 8, 2016

As I'm starting to actively working on Piwik 3 basically today I need to create "develop" branches. We already have a 3.0 branch that I would rename. Re handling Piwik 2 and 3 see here: #9806 and we also need a develop branch anyway as it is the only way to make sure we always have a green build in master.

Are there any good examples from other projects? Maybe any "standards"? I was thinking about simply using 2_X and 3_X as develop branches for 2.X and 3.X. We won't exactly follow git flow or so, instead we want to keep things simple for us. If there are any opinions please comment ASAP as I need to start creating such branches for several plugins, otherwise I can't get the tests in 3.0 branch green.
@tsteur tsteur added the RFC Indicates the issue is a request for comments where the author is looking for feedback. label Mar 8, 2016
@tsteur tsteur added this to the 2.16.1 milestone Mar 8, 2016
@kaz231
Copy link

kaz231 commented Mar 8, 2016

Maybe something like 2.X-dev ?

@mattab
Copy link
Member

mattab commented Mar 8, 2016

Maybe 2.x and 3.x ?

@tsteur
Copy link
Member Author

tsteur commented Mar 8, 2016

I reckon adding a -dev does make sense and is more clear. 👍 for that. Eg 2.x-dev (lowercase is easier to write on console :-) ). Any more ideas?

@tsteur
Copy link
Member Author

tsteur commented Mar 9, 2016

If I hear no complaints in the next few hours 3.x-dev and 2.x-dev it is :)

This was referenced Mar 9, 2016
Merged
Closed
Merged
@tsteur tsteur closed this as completed Mar 9, 2016
@mattab
Copy link
Member

mattab commented Mar 15, 2016

👍

@mattab mattab mentioned this issue May 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC Indicates the issue is a request for comments where the author is looking for feedback.
Projects
None yet
Milestone
2.16.1
Development

No branches or pull requests
3 participants
@tsteur @mattab @kaz231