Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve password reset confirmation mail text #9879

Merged
merged 1 commit into from Mar 6, 2016
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 5, 2016

Improves password reset confirmation mail text to inform user that token_auth will change aswell.

New text will be:

Hi %1$s,

A password reset request was received from %2$s. To confirm this password change so you can login with your new credentials, visit the following link:\n\n%3$s

Attention: Changing the password will also change your token_auth. You can look up your new token_auth on your settings page.

Note: this token will expire in 24 hours.

And thank you for using Piwik!

refs #9833

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 5, 2016
@@ -12,7 +12,7 @@
"LoginOrEmail": "Username or E-mail",
"LoginPasswordNotCorrect": "Wrong Username and password combination.",
"LostYourPassword": "Lost your password?",
"MailPasswordChangeBody": "Hi %1$s,\n\nA password reset request was received from %2$s. To confirm this password change so you can login with your new credentials, visit the following link:\n\n%3$s\n\nNote: this token will expire in 24 hours.\n\nAnd thank you for using Piwik!",
"MailPasswordChangeBody": "Hi %1$s,\n\nA password reset request was received from %2$s. To confirm this password change so you can login with your new credentials, visit the following link:\n\n%3$s\n\nAttention: Changing the password will also change your token_auth. You can look up your new token_auth on your settings page.\n\nNote: this token will expire in 24 hours.\n\nAnd thank you for using Piwik!",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe add something like "If you are using your API token in any external applications or for archiving, make sure to update the token as requests to the API will fail otherwise."?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Will add that...

@tsteur
Copy link
Member

tsteur commented Mar 6, 2016

Should we maybe also show a warning here?

image

Eg "Changing your password will also change your API token. This token is used for example in the Piwik Mobile app." or maybe we show it instead in success message?

https://github.com/piwik/piwik-ui-tests/blob/master/Login_password_reset_complete.png

@tsteur
Copy link
Member

tsteur commented Mar 6, 2016

I'm not sure where to change it and if. Just asking :)

@sgiehl
Copy link
Member Author

sgiehl commented Mar 6, 2016

Thought about adding it there, but actually the token is changed when clicking on the link in the mail.
Adding it to the form might maybe look like it will be changed when submitting the form.

@tsteur
Copy link
Member

tsteur commented Mar 6, 2016

👍

tsteur added a commit that referenced this pull request Mar 6, 2016
Improve password reset confirmation mail text
@tsteur tsteur merged commit 027427f into master Mar 6, 2016
@tsteur tsteur deleted the changepwmail branch March 6, 2016 21:32
@mattab
Copy link
Member

mattab commented Mar 15, 2016

FYI: tweaked the message further (for consistency) in 409fb2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants