Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transitions should work as expected even when used along with a Goal segment #9873

Merged
merged 3 commits into from Mar 10, 2016
Merged

Transitions should work as expected even when used along with a Goal segment #9873

merged 3 commits into from Mar 10, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Mar 3, 2016

  • We add a system reproducing the issue
  • we fix the issue by prefixing the DB field by the table alias, to prevent error when a segment joins another table that has some field names in common

fixes #9822

@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 3, 2016
@mattab mattab added this to the 2.16.1 milestone Mar 3, 2016
@mattab mattab mentioned this pull request Mar 3, 2016
Closed
sgiehl
sgiehl reviewed Mar 3, 2016
View reviewed changes
plugins/Transitions/API.php
@@ -222,7 +222,8 @@ protected function queryFollowingActions($idaction, $actionType, LogAggregator $
if ($actionType != 'title') {
// specific setup for page urls
$types[Action::TYPE_PAGE_URL] = 'followingPages';
$dimension = 'if ( idaction_url IS NULL, idaction_name, idaction_url )';
$dimension = 'if ( %s.idaction_url IS NULL, %s.idaction_name, %s.idaction_url )';
$dimension = str_replace('%s', 'log_link_visit_action', $dimension );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for not using sprintf here and below?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for sprintf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible to use sprintf but we need to replace %s by %1$s in all 3 occurrences. Otherwise we get sprintf(): Too few arguments. Shall I do it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, use %1$s

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done

mattab pushed a commit that referenced this pull request Mar 10, 2016
Merge pull request #9873 from piwik/9822
5d14d8a 
Transitions should work as expected even when used along with a Goal segment
@mattab mattab merged commit 5d14d8a into master Mar 10, 2016
@mattab mattab deleted the 9822 branch March 15, 2016 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattab @tsteur @sgiehl