Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piwik.js: handle clickable phone number 'tel:' #9865

Closed
Glisse1 opened this issue Mar 2, 2016 · 3 comments
Closed

Piwik.js: handle clickable phone number 'tel:' #9865

Glisse1 opened this issue Mar 2, 2016 · 3 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
2.16.1

Comments

@Glisse1
Copy link

Glisse1 commented Mar 2, 2016

Hello,
Ever since I have started to use piwik I have this bug. Probably I am in a very small minority, but here it is:

  • in mobile version of my site I have a widget formatted to be directly clicked for dialing my number. The link is the standard html recommended one, <a href="tel:012345678">012345678</a>
  • when a customer clicks this link it leaves the browser and dials the number as expected, but on piwik end I get some sort of "unknown" page listed as the action-url (not an outgoing link, as I believe it should).. at this point piwik freezes and stops auto-refreshing the live widget
@sgiehl
Copy link
Member

sgiehl commented Mar 2, 2016

Not sure how it should be tracked at all.
But as tel-links should imho be handled the same way as mailtio-links, it needs to be added in https://github.com/piwik/piwik/blob/master/js/piwik.js#L4155 I guess

@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Mar 6, 2016
@tsteur tsteur added this to the 2.16.1 milestone Mar 6, 2016
@tsteur
Copy link
Member

tsteur commented Mar 6, 2016

Good point, I'll add it to 2.16.1 as it seems like a quick fix but we can also move it out of 2.16.

@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Mar 6, 2016
@sgiehl sgiehl mentioned this issue Mar 7, 2016
Merged
@tsteur
Copy link
Member

tsteur commented Mar 8, 2016

I tested and debugged it, and what happens now, is that nothing is tracked when clicking on tel:0123456... This seems to be same behaviour as for mailto. Tracking mailto, tel, ... links would be another new feature I presume.

@tsteur tsteur closed this as completed Mar 8, 2016
@mattab mattab changed the title Clickable phone number freezes piwik Piwik.js: handle clickable phone number 'tel:' Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
2.16.1
Development

No branches or pull requests
3 participants
@tsteur @sgiehl @Glisse1