Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'option' table with no prefix #985

Closed
robocoder opened this issue Sep 15, 2009 · 3 comments
Closed

'option' table with no prefix #985

robocoder opened this issue Sep 15, 2009 · 3 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

OPTION is still a reserved keyword in MySQL (became non-reserved in SQL:2003 spec).

When the table prefix is empty "", the table name must be backticked (in MySQL). However, backticking is not portable SQL. Removing backticks in pre-processing adds overhead.

Proposals:

  • table prefix mandatory (require at least one character)
  • rename table (note: OPTIONS is a non-reserved keyword)

Note: in either proposal, an external update script would be needed to execute the ALTER statements needed to rename tables.
Keywords: wishlist
@mattab
Copy link
Member

mattab commented Sep 22, 2009

vote for wontfix, and move the "table quoting" to the DB adapter

@mattab
Copy link
Member

mattab commented Mar 30, 2010

marking as wontfix - if we need to change it, please reopen

@robocoder
Copy link
Contributor Author

At minimum, we should consider the first proposal (require at least one leading alpha character in $tables_prefix).

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @robocoder