Fix dashboard interaction with menu #9845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
sgiehl
force-pushed
the
fixdashboardmenu
branch
from
4d1029b
to
c6e149a
Compare
sgiehl
force-pushed
the
fixdashboardmenu
branch
from
c6e149a
to
1d95f98
Compare
|
LGTM but http://builds-artifacts.piwik.org/piwik/piwik/fixdashboardmenu/18149/Dashboard_create_new seems to fail? |
|
It works otherwise 👍 |
|
Don't think it fails. The test was skipped before, and I guess the screenshot was maybe outdated. See https://github.com/piwik/piwik/pull/9845/files#diff-bb8133931a30cab56862c5d8dceda8eaL209 |
|
Oki. Wasn't sure if it was outdated or not. LGTM in this case 👍 |
sgiehl
added a commit
that referenced
this pull request
Feb 26, 2016
Fix dashboard interaction with menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the problems described in #9750
to ensure those features still work in the future, I've added some UI tests
fixes #9750