Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql database name with + #9844

Closed
goretkin opened this issue Feb 24, 2016 · 1 comment
Closed

mysql database name with + #9844

goretkin opened this issue Feb 24, 2016 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.16.2

Comments

@goretkin
Copy link

The database name I can use contains a +. During setup Piwik tells me that's an invalid database name.

I don't follow the code perfectly, but it looks like it boils down to
https://github.com/piwik/piwik/blob/7f375924db9328f20a0b7cb1e41397f2309b60a7/plugins/Installation/FormDatabaseSetup.php#L63

and then

https://github.com/piwik/piwik/blob/7f375924db9328f20a0b7cb1e41397f2309b60a7/core/Filesystem.php#L54

I'm going to try the regular expression (^[a-zA-Z0-9]+([a-zA-Z_0-9.-\\+]*))$ instead
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Feb 25, 2016
@tsteur
Copy link
Member

tsteur commented Feb 25, 2016

Thx! This is a bug and we probably should allow a + in database name

@mattab mattab modified the milestones: 2.16.x (LTS), Mid term Mar 31, 2016
This was referenced Apr 24, 2016
Closed
Merged
@mattab mattab closed this as completed Aug 2, 2016
@mattab mattab modified the milestones: 2.16.2, Mid term Aug 2, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.2
Development

No branches or pull requests
3 participants
@tsteur @mattab @goretkin