Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong statistic if same parameter is used several times in the query string #9842

Open
rristow opened this issue Feb 24, 2016 · 5 comments
Open

Wrong statistic if same parameter is used several times in the query string #9842

rristow opened this issue Feb 24, 2016 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Data Integrity & Accuracy
Milestone
Backlog (Help wan...

Comments

@rristow
Copy link

rristow commented Feb 24, 2016

Piwik (php) will not store the complete URI if the query part of the URI has more than one parameter with the same key/name. e.g.
http:/mydomain.com?selected_colors=red&selected_colors=blue&par3=1

It's a little bit strange to have parameter with the same name, but there are some systems that use this technic (like plone4) and I didn't find a clear definition about this in the "rfc3986".
The main problem is that the link in the reports (like 'Visitor Profile report') will be truncate . e.g.
http:/mydomain.com?selected_colors=red&par3=1
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 25, 2016
@tsteur
Copy link
Member

tsteur commented Feb 25, 2016

Thank you @rristow Independent of any rfc I would say this is a bug. Piwik should not change the URL that was sent via the Tracking API. I think eg in angular this is valid and someone would get an array for selected_colors in this case

@rristow
Copy link
Author

rristow commented Mar 10, 2016

Is there a workaround for this?

@tsteur tsteur mentioned this issue Mar 10, 2016
Closed
@tsteur
Copy link
Member

tsteur commented Mar 10, 2016

Unfortunately I cannot think of any workaround for this right now

mattab added a commit that referenced this issue Mar 14, 2016
@mattab
Refs #9842 Add Unit test showcasing the issue
2ed6ba1
@mattab mattab modified the milestones: 2.16.x (LTS), 3.0.0 Mar 31, 2016
@rristow rristow changed the title URI.query - parameters with the same name and different values Wrong statistic if same parameter is used several times in the query string Apr 9, 2017
@webmaxttor
Copy link

webmaxttor commented Apr 9, 2017 •
edited

@mattab - All forms with lists are actually "misinterpreted" in piwik. Is this bug not serious?
Because campains can be based on survey-forms. And all answers from lists, check-boxes, etc... will be "wrong" in piwik.
Take a look here:
http://stackoverflow.com/questions/724526/how-to-pass-multiple-parameters-in-a-querystring
https://msdn.microsoft.com/en-us/library/ms524784(v=vs.90).aspx

@rristow
Copy link
Author

rristow commented May 8, 2017

@mattab - May I ask if there some input here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Data Integrity & Accuracy
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
4 participants
@tsteur @mattab @rristow @webmaxttor