Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreplaced translations in transitions #9800

Merged
merged 1 commit into from Feb 18, 2016
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 17, 2016

Another case where %s has been replaced manually.
To avoid that I've replace this and other occurrences with usage of sprintf.
Also adjusted the transitions UI test to hover a number, so the tooltip is displayed where replacing didn't work.

fixes #9799

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 17, 2016
@sgiehl sgiehl added this to the 2.16.1 milestone Feb 17, 2016
@tsteur
Copy link
Member

tsteur commented Feb 18, 2016

Looks good, now we can even see the tooltip here again http://builds-artifacts.piwik.org/piwik/piwik/fixtransitiontranslations/18097/Transitions_transitions_popup_urls

Tested it locally and worked 👍

tsteur added a commit that referenced this pull request Feb 18, 2016
Fix unreplaced translations in transitions
@tsteur tsteur merged commit 75d7efb into master Feb 18, 2016
@tsteur tsteur deleted the fixtransitiontranslations branch February 18, 2016 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants