Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added package.json #9786

Closed
wants to merge 2 commits into from
Closed

Conversation

nagyadam2092
Copy link

Hello!

package.json is needed if someone wants to reach this repository via npm, so I added it.
Please check the information I wrote there.

Thank you,
Adam

@nagyadam2092
Copy link
Author

any chance to merge this request soon?

"analytics"
],
"dependencies": {},
"license": "GPL v3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call license: GPLv3 or later?

@tsteur
Copy link
Member

tsteur commented Feb 18, 2016

In our bower.json we have some files to ignore specified. Like

"ignore": [
    "**/.*",
    "node_modules",
    "tests"
  ]

Is this possible with NPM as well? Or maybe we live the tests there as it will be only used for development via NPM. We always recommend to download the prepared ZIP file from piwik.org for deploying Piwik on production systems since it makes sure to remove test files and unneeded plugins etc.

Also, we might need to give some instructions on how to proceed with Piwik installation maybe? Eg Piwik won't work after fetching Piwik via NPM as it will be still needed to run Composer to fetch all PHP dependencies specified here. https://github.com/piwik/piwik/blob/2.16.0/composer.json#L38-L60

@mattab
Copy link
Member

mattab commented Feb 20, 2016

(fyi @nagyadam2092 this FAQ lists instructions how to initialise Piwik when fetched from Git http://piwik.org/faq/how-to-install/faq_18271/ )

@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Mar 14, 2016
@mattab
Copy link
Member

mattab commented Mar 14, 2016

Hi @nagyadam2092
could you maybe check the review/feedback above so we can consider merging your PR?

@mattab mattab added this to the 2.16.x milestone Mar 14, 2016
@mattab mattab modified the milestones: 2.16.x (LTS), Mid term Apr 1, 2016
@mattab
Copy link
Member

mattab commented Jul 25, 2016

Thank you for this proposed pull request.

Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit).

We hope you understand this and we look forward to seeing an update from you on this pull request or another one!

Thanks.

@mattab mattab closed this Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants