Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing package.json #9783

Open
nagyadam2092 opened this issue Feb 15, 2016 · 5 comments
Open

Missing package.json #9783

nagyadam2092 opened this issue Feb 15, 2016 · 5 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone
Backlog (Help wan...

Comments

@nagyadam2092
Copy link

Hello!

I want to download this repo via npm, but there is no package.json, so it fails to download the repo.
Could you please give a package.json to the project?

Thank you,
Adam
@tsteur
Copy link
Member

tsteur commented Feb 16, 2016

Hey @nagyadam2092 feel free to issue a pull request for this. You can download this repo via https://getcomposer.org/ by the way.

@mattab
Copy link
Member

mattab commented Mar 31, 2016

@nagyadam2092 Pull request welcome!

@mattab mattab added this to the Mid term milestone Mar 31, 2016
@mattab mattab added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Mar 31, 2016
@Findus23
Copy link
Member

this is a bit related to #12067

I am not sure if it is a good idea to let people install piwik via npm, as it has the same implications as installing via git or composer (need to fetch submodules and composer dependecies, etc.)

@davidbarratt
Copy link

Well it would be really nice to have the JS tracker in npm. That way it can be bundled with webpack, etc.

@Findus23
Copy link
Member

Keep in mind that plugins can and need to modify the piwik.js to work properly.
But if you don’t care about this, a minimal package including just the js/ folder should be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
5 participants
@tsteur @mattab @davidbarratt @nagyadam2092 @Findus23