Reuse datatable's metadata when merging subtables #9778
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #9773 the all referrers goal metrics didn't contain the goal names.
After debugging a while I found out, that this is caused by
DataTable::mergeSubtables
, which is used to create the report. This method returns a complete newDataTable
object. The metadata of the original datatable is lost.As the
site
metadata is so missing in the newDataTable
object, the goal metrics are not able to load the goal name.Copying the metadata to the new datatable object fixes this issue.
Not sure if that might have any side effects...
fixes #9773