Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Goal conversions, conversion rate, for each Device type, Device name, Device model #9777

Closed
mattab opened this issue Feb 13, 2016 · 8 comments · Fixed by #10873
Closed
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Needs Review PRs that need a code review
Milestone

Comments

@mattab
Copy link
Member

mattab commented Feb 13, 2016

Currently we process Goal conversions and Conversion rates for each of the following dimensions:

dimensions goals

Goal of this issue is to add "Device type" at least to these dimensions, so that one can know the conversion rate per device type, for each goal. It would be valuable to know conversion rates of Desktop VS Mobile VS Table!

@mattab mattab modified the milestones: Long term, Mid term Mar 31, 2016
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Mar 31, 2016
@sgiehl sgiehl self-assigned this Apr 10, 2016
@mattab
Copy link
Member Author

mattab commented Sep 27, 2016

Fixed in #10070 - will be released in Piwik 3 👍

@mattab mattab closed this as completed Sep 27, 2016
@mattab mattab modified the milestones: 3.0.0-b1, Mid term Sep 27, 2016
@mattab
Copy link
Member Author

mattab commented Sep 27, 2016

I just tried it on demo3 and i'm not yet sure that it's working well, as it seems almost all conversions are attributed to "device type = Unknown" whereas only 0.5% of all visits are unknown.. I'd expect only 0.5% of conversions (on average) to be attributed to unknown

@sgiehl can you take a look at https://demo3.piwik.org/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=2016-09-21&category=Goals_Goals&subcategory=3

@mattab mattab reopened this Sep 27, 2016
@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0-b1 Sep 27, 2016
@mattab mattab added the Needs Review PRs that need a code review label Sep 27, 2016
@sgiehl
Copy link
Member

sgiehl commented Sep 27, 2016

Can't find the credentials for demo3 right now, but you seem to have requested an older report. As the dimension fields in goal report didn't exist before, the data can only be available for new requests.

@mattab
Copy link
Member Author

mattab commented Sep 27, 2016

sent you creds to demo3

As the PR was merged 27 days ago, we should have valid data for about 3+ weeks but I'm not seeing good data recently, even for yesterday. let me know what you find!

@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0-b3 Oct 30, 2016
@mattab mattab modified the milestones: 3.0.0-b4, 3.0.0-b3 Nov 14, 2016
@mattab
Copy link
Member Author

mattab commented Nov 14, 2016

Seems not to have data on https://demo-anonymous.piwik.org/index.php?module=CoreHome&action=index&idSite=1&period=year&date=today#?idSite=1&period=year&date=today&category=Goals_Goals&subcategory=1 neither. trying to create a new goal to have more data soon.

Not sure yet if the feature works as expected, will check

@sgiehl
Copy link
Member

sgiehl commented Nov 14, 2016

I found the problem:
https://github.com/piwik/piwik/blob/3.x-dev/plugins/DevicesDetection/Columns/DeviceType.php#L73 always returns false (if the goal conversion isn't the first tracking request).

Not sure why that's the case. Thought the visitor properties should be filled with the data saved in the database. Will have a closer look at that later

@mattab
Copy link
Member Author

mattab commented Nov 20, 2016

Will check on demo3 in coming days

@mattab mattab reopened this Nov 20, 2016
@mattab
Copy link
Member Author

mattab commented Dec 1, 2016

It works, well done @sgiehl 👍

@mattab mattab closed this as completed Dec 1, 2016
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Dec 2, 2016
@mattab mattab changed the title Process Goal conversions, conversion rate, for each Device Type Process Goal conversions, conversion rate, for each Device type, Device name, Device model Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants