Apply offset and limit correctly to the Visitor Log SQL queries #9774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
not-in-changelog
|
when a SQL query is wrapped ie. there is an inner query and an outer query (for example when segments are used and joins are done in a sub-query), the offset and limit is applied to the inner query. The offset should not be applied to the outer query since applying the offset twice will always result in the outer query returning no data. |
mattab
pushed a commit
that referenced
this pull request
Mar 10, 2016
Apply offset and limit correctly to the Visitor Log SQL queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9200