Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugins update respect enable_auto_update #9751

Open
mathieubouchard opened this issue Feb 11, 2016 · 8 comments
Open

Make plugins update respect enable_auto_update #9751

mathieubouchard opened this issue Feb 11, 2016 · 8 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@mathieubouchard
Copy link

There's no validation for the value of enable_auto_update before checking if there are plugin updates, which is triggering timeouts when accessing the admin web pages.

If enable_auto_update is set to 0, there should have no check for :

  • Piwik update (OK)
  • Plugins update (plugins/CorePluginsAdmin/MarketplaceApiClient.php)
  • Spam user blacklist update (./plugins/CoreAdminHome/Tasks.php)
  • GeoIP update (./plugins/UserCountry/GeoIPAutoUpdater.php)
  • etc. ?
@tsteur
Copy link
Member

tsteur commented Feb 11, 2016

Good point, I presume we should respect that setting in the Marketplace. I will see what is possible probably today.

FYI: So far the workflow would be to disable the Marketplace for this by setting [General]enable_marketplace=0.
We will soon introduce a new setting multi_server_environment = 0/1 which then will disable some updates as well. More about this will follow soon.

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 11, 2016
@hpvd
Copy link

hpvd commented Feb 11, 2016

hmm I'm not that happy making it global
(like decribed in ticket details but not in headline)

Update of data like geo-IP, Spam-protection ... should be handeled separately.

What do you think of making 2 switches,

  • one for all kind of software (Piwik itself and all plugins) and
  • one for all kind of data (geio, spam etc)

the reason:

  • software could introduce new bugs or incompatibilities which one may want check manually
  • simple data updates shouldn't break anything but only make things better

btw All update checks could use the same messaging sytem "there is a new update available"

@tsteur
Copy link
Member

tsteur commented Feb 11, 2016

I won't make it global for geoi and spam for now :)

@hpvd
Copy link

hpvd commented Feb 11, 2016

good to hear!

@tsteur tsteur added this to the 2.16.1 milestone Feb 11, 2016
@tsteur tsteur self-assigned this Feb 11, 2016
@mattab
Copy link
Member

mattab commented Feb 11, 2016

Notes:

  • enable_auto_update - is currently wrongly implemented. it disables the "Check for new versions" when it should only disable the "Auto update" feature
  • we would need a new setting enable_check_latest which would let users disable the actual check for latest version (for core and for marketplace plugins).

@tsteur
Copy link
Member

tsteur commented Feb 11, 2016

Actually, I will remove this issue out of the current milestone again. The setting enable_auto_update should actually disable all automatic updates, or at least core and plugins.

What I will do as part of another feature is to show a "download plugin" button instead of an "update plugin" or "install plugin" if enable_auto_update is disabled. However, it will still ping the Marketplace so far. For this we will need another setting like suggested enable_check_latest or enable_outgoing_requests_to_piwik or something.

@tsteur tsteur removed this from the 2.16.1 milestone Feb 11, 2016
@tsteur tsteur removed their assignment Feb 11, 2016
@mattab
Copy link
Member

mattab commented Feb 11, 2016

For this we will need another setting like suggested enable_check_latest or enable_outgoing_requests_to_piwik or something.

FYI enable_outgoing_requests_to_piwik is covered in #6324

@mathieubouchard
Copy link
Author

I added a list of outgoing connections to #6324

@mattab mattab added this to the Long term milestone Mar 31, 2016
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants