Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds test for numbered placeholder usage #9728

Merged
merged 1 commit into from Feb 10, 2016
Merged

Adds test for numbered placeholder usage #9728

merged 1 commit into from Feb 10, 2016

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 7, 2016

I've already updated all translation keys not to use multiple %s anymore.
This test ensures that all translations will use numbered placeholders in the future.

fixes #9546

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 7, 2016
@sgiehl sgiehl added this to the 2.16.1 milestone Feb 7, 2016
@sgiehl sgiehl mentioned this pull request Feb 7, 2016
Closed
4 tasks
tsteur added a commit that referenced this pull request Feb 10, 2016
@tsteur
Merge pull request #9728 from piwik/testnumberedplaceholders
8e525f5 
Adds test for numbered placeholder usage
@tsteur tsteur merged commit 8e525f5 into master Feb 10, 2016
@tsteur tsteur deleted the testnumberedplaceholders branch February 10, 2016 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur