Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day names not displayed in some languages #9717

Closed
simpleuser99 opened this issue Feb 5, 2016 · 5 comments
Closed

Day names not displayed in some languages #9717

simpleuser99 opened this issue Feb 5, 2016 · 5 comments
Assignees
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: i18n For issues around internationalisation and localisation. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@simpleuser99
Copy link

Hello.
Since I update piwik to 2.15.0 , I didn't view day of week. I thought when I update to 2.16 version, these bug be fix. Unfortunately there is a bug.

piwik_bug

How can I fix it?

@sgiehl
Copy link
Member

sgiehl commented Feb 5, 2016

What exactly is the problem? Would you mind switching to english and check if it still appears?

@simpleuser99
Copy link
Author

THe problem is i do not view day of week on russian language. But I view day of weeks if I use english
piwik_en
Compare screenshots please. In english i view that day of week is Sun(Sunday), but in russian version I don't view day of week. Understand?

@sgiehl
Copy link
Member

sgiehl commented Feb 5, 2016

Ah, ok. Now that's clear for me what the problem is. thx
Will have a look.

@sgiehl sgiehl self-assigned this Feb 5, 2016
@sgiehl
Copy link
Member

sgiehl commented Feb 5, 2016

Guess I found the problem.

You could try to fix it by updating this file:
https://github.com/piwik/piwik/blob/master/core/Date.php#L721-L725

Simply replace all the uppercase "C" with a lowercase "c" in the marked lines.

Need to test that later, then I will issue a PR to fix it

@sgiehl sgiehl added this to the 2.16.1 milestone Feb 5, 2016
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. c: i18n For issues around internationalisation and localisation. labels Feb 5, 2016
@simpleuser99
Copy link
Author

I manual change "C" to "c" and I have good result. Thx!

sgiehl added a commit that referenced this issue Feb 5, 2016
@mattab mattab modified the milestones: 2.16.x, 2.16.1 Feb 6, 2016
@sgiehl sgiehl changed the title Do not view day of week Day names not displayed in some languages Feb 7, 2016
@mattab mattab added answered For when a question was asked and we referred to forum or answered it. and removed answered For when a question was asked and we referred to forum or answered it. labels Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: i18n For issues around internationalisation and localisation. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

No branches or pull requests

3 participants