Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceError: DataTable_RowActions_Transitions is not defined #9704

Closed
CannyDuck opened this issue Feb 4, 2016 · 14 comments
Closed

ReferenceError: DataTable_RowActions_Transitions is not defined #9704

CannyDuck opened this issue Feb 4, 2016 · 14 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@CannyDuck
Copy link

After upgrading my installation to 2.16.0 I get this JavaScript error and see no stats anymore:

ReferenceError: DataTable_RowActions_Transitions is not defined Quelldatei: .../index.php?module=Proxy&action=getCoreJs&cb=43f191bb6d2019ae495832ef5f01689c Zeile: 2062

@sgiehl
Copy link
Member

sgiehl commented Feb 4, 2016

Please try cleaning the tmp directory of Piwik.

@CannyDuck
Copy link
Author

I deleted all files from the tmp directory. No change, the error still occurs.

@sgiehl
Copy link
Member

sgiehl commented Feb 4, 2016

Could you look up a more detailed error description with maybe a stack trace in the dev tools of your browser?

@CannyDuck
Copy link
Author

Affected code:

DataTable_RowActions_Transitions.registerReport({isAvailableOnReport:function(dataTableParams){return isPageUrlReport(dataTableParams);},isAvailableOnRow:function(dataTableParams,tr){return isPageUrlReport(dataTableParams)&&tr.find('> td:first span.label').parent().is('a')},trigger:function(tr,e,subTableLabel){var link=getLinkForTransitionAndOverlayPopover(tr);this.openPopover('url:'+link);}});DataTable_RowActions_Transitions.registerReport({isAvailableOnReport:function(dataTableParams){return isPageTitleReport(dataTableParams);},isAvailableOnRow:function(dataTableParams,tr){return isPageTitleReport(dataTableParams);},trigger:function(tr,e,subTableLabel){DataTable_RowAction.prototype.trigger.apply(this,[tr,e,subTableLabel]);}});DataTable_RowActions_Overlay.registerReport({isAvailableOnReport:function(dataTableParams){return isPageUrlReport(dataTableParams);},onClick:function(actionA,tr,e){return{link:getLinkForTransitionAndOverlayPopover(tr),segment:null}}});});

@tsteur
Copy link
Member

tsteur commented Feb 4, 2016

Can you check if the Transitions plugin is enabled in "Administration => Plugins"?

This is a bug as we're not checking everywhere whether this row action is actually available. We either need to load transitions.js in CoreHome or check for availability of this class

@tsteur tsteur closed this as completed Feb 4, 2016
@tsteur tsteur reopened this Feb 4, 2016
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 4, 2016
@tsteur tsteur added this to the 2.16.1 milestone Feb 4, 2016
@chris246
Copy link

chris246 commented Feb 4, 2016

Same bug here

@tsteur
Copy link
Member

tsteur commented Feb 4, 2016

Can you check if the Transitions plugin is enabled in "Administration => Plugins"? This will solve it for now.

@CannyDuck
Copy link
Author

That solved it for me. Thanks.

@chris246
Copy link

chris246 commented Feb 4, 2016

It is.
I've disabled and re-enabled it - no effect.
And I've cleared the tmp-directory.

@tsteur
Copy link
Member

tsteur commented Feb 4, 2016

Did you clear the browser cache?

@tsteur
Copy link
Member

tsteur commented Feb 4, 2016

FYI: Issues fix for this here: #9713

@chris246
Copy link

chris246 commented Feb 4, 2016

Used Ctrl + F5 to reload (Firefox 44.0)

Thanks

@chris246
Copy link

chris246 commented Feb 5, 2016

Sorry, in my case, the Overlay-Plugin was disabled.
Re-enabling fixed the issue.
Maybe you want to extend fix #9713

@mattab mattab changed the title Error after upgrade to 2.16.0 ReferenceError: DataTable_RowActions_Transitions is not defined Feb 5, 2016
@mattab mattab modified the milestones: 2.16.1, 2.16.x Feb 6, 2016
@tsteur
Copy link
Member

tsteur commented Feb 7, 2016

Thx for letting us know @chris246 . There should be a fix for Overlay plugin in #9713

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

5 participants