Fix XML or other response renderer header are not set #9699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eg causes http://demo.piwik.org/index.php?module=API&method=Live.getLastVisitsDetails&format=XML&idSite=7&period=month&date=2016-01-12&expanded=1&token_auth=&filter_limit=10 to be returned as plain text. Problem: Within the response renderer, in `handleDataTable`, after the API request was executed and the correct header already set, we perform another API request by https://github.com/piwik/piwik/blob/master/plugins/Intl/DateTimeFormatProvider.php#L110 which then sets a plain header. Quick workaround is to just send it again. Possibly better workaround is to not set a header when `original` render is used. Or to only set it when `serialized=1` here: https://github.com/piwik/piwik/blob/master/plugins/API/Renderer/Original.php#L53 We could change it to ```php if ($this->shouldSerialize()) { Common::sendHeader('Content-Type: text/plain; charset=utf-8'); } ```
tsteur
added
not-in-changelog
|
I'd be happy to issue another PR for the other fix |
tsteur
added a commit
that referenced
this pull request
Feb 4, 2016
|
Closing this one in favour of #9700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eg causes http://demo.piwik.org/index.php?module=API&method=Live.getLastVisitsDetails&format=XML&idSite=7&period=month&date=2016-01-12&expanded=1&token_auth=&filter_limit=10 to be returned as plain text.
Problem: Within the response renderer, in
handleDataTable, after the API request was executed and the correct header already set, we perform another API request by https://github.com/piwik/piwik/blob/master/plugins/Intl/DateTimeFormatProvider.php#L110 which then sets a plain header.Quick workaround is to just send it again. Possibly better workaround is to not set a header when
originalrender is used. Or to only set it whenserialized=1here: https://github.com/piwik/piwik/blob/master/plugins/API/Renderer/Original.php#L53We could change it to