Fix translation usage in datatable footer #9675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
| if (/(%(.\$)?s+)/g.test(_pk_translate(text))) { | ||
| var values = ['<br /><span class="action">» ']; | ||
| if(replacement) { | ||
| values.push(replacement); |
There was a problem hiding this comment.
I haven't tested it yet but does it actually do the same? I think before it was maybe replacing the first %s with self.props.pivot_dimension_name and now it's maybe the second %s (replacement)
mattab
pushed a commit
that referenced
this pull request
Feb 2, 2016
Fix translation usage in datatable footer
|
Works for me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9670