Test for PR #9486, Validate allowed TLDs with current IANA list #9674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianpiskorski
changed the title
sebastianpiskorski
force-pushed
the
9486_test_case
branch
from
c0307ed
to
b2f16c1
Compare
| @@ -8,6 +8,9 @@ | |||
|
|
|||
| namespace Piwik\Tests\Integration; | |||
|
|
|||
| use Guzzle\Http\Client; | |||
| use Guzzle\Http\Message\Request; | |||
| use Guzzle\Http\Message\Response; | |||
There was a problem hiding this comment.
FYI: While guzzle is a library in Piwik it is only there for AWS-SDK. It's not a supported lib and we might remove it at some point. Instead use Piwik\Http.
|
I will fix those soon. |
mattab
added
the
Pull Request WIP
sebastianpiskorski
force-pushed
the
9486_test_case
branch
from
b2f16c1
to
88ad8c9
Compare
|
Introduced CR suggestions. |
tsteur
added
Needs Review
tsteur
added
the
not-in-changelog
|
@sebastianpiskorski @tsteur This PR introduces a little challenge, see: Automated test for allowed TLDs starts failing when iana.org starts supporting new domain extensions #9977 |
|
I think it's supposed to fail in such a case to make sure it'll work for all domains in the future. That's why I merged it. Not sure how often they add new domains though. If they add new ones too often could maybe solve it differently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9486