Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation strings show up with placeholders in UI #9670

Closed
mattab opened this issue Feb 1, 2016 · 1 comment
Closed

Translation strings show up with placeholders in UI #9670

mattab opened this issue Feb 1, 2016 · 1 comment
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
2.16.0

Comments

@mattab
Copy link
Member

mattab commented Feb 1, 2016

This regressed I think from #9546 - some of the strings are displayed with placeholders in the UI eg.

not translated

ping @sgiehl
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Feb 1, 2016
@mattab mattab added this to the 2.16.0 milestone Feb 1, 2016
@tsteur
Copy link
Member

tsteur commented Feb 1, 2016

Possibly caused by https://github.com/piwik/piwik/blob/2.16.0-rc1/plugins/CoreHome/javascripts/dataTable.js#L1313 ?

Maybe translation should be changed to This report is not pivoted %1$s Pivot by %1$s and then we update the line in JavaScript

@sgiehl sgiehl self-assigned this Feb 1, 2016
@sgiehl sgiehl mentioned this issue Feb 1, 2016
Merged
sgiehl added a commit that referenced this issue Feb 1, 2016
@sgiehl
fixes #9670 fix translation usage in datatable footer
7636392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @sgiehl