Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivot is not correctly remembered #9667

Closed
tsteur opened this issue Jan 31, 2016 · 0 comments
Closed

Pivot is not correctly remembered #9667

tsteur opened this issue Jan 31, 2016 · 0 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Jan 31, 2016

To reproduce:

  • Eg go to "Visitors => Custom variables"
  • Select "Pivot report" via cog icon
  • Open any other report
  • Go back to "Visitors => Custom variables"
  • It says the report is pivoted but it is not

Problem: The HtmlTable visualization is applied instead of PivotBy because there is no URL parameter that says "pivot is used" here: https://github.com/piwik/piwik/blob/2.16.0-rc1/plugins/CoreVisualizations/CoreVisualizations.php#L46-L50

The decision which visualization to use is made later by saved ViewDataTable parameters but we have to decide which of those two visualizations we want to use earlier. To solve this we need to give Pivot visualization a unique name (Visualization ID). This sounds easy but it is not that trivial since we somehow still need to disable HtmlTable visualization in such a case. There must be better solutions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants