Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Management in Dashboard is not accounting for user logins from Android devices and possibly iOS. #9664

Open
xymantec opened this issue Jan 30, 2016 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Data Integrity & Accuracy

Comments

@xymantec
Copy link

I have multiple users who use Piwiks on their Android devices, the dashboard specifically the User Management section does not account for this usage as activity/logins and display the users as not having logged in a very long time (for example: Last Seen: 6271:13:37), This should be fixed to display android connections to the site as valid logins or else we can't really tell if users check their statistics if they don't actually log into the dashboard with a desktop.

Server is running the latest Piwik 2.15.0

Note: it would be a nice feature to see if the user uses their desktop or smartphone as well aside from the last time they are seen.

@xymantec xymantec changed the title User Management in Dashboard is not accounting for user logins from Android devices and possible iOS. User Management in Dashboard is not accounting for user logins from Android devices and possibly iOS. Jan 30, 2016
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 31, 2016
@tsteur
Copy link
Member

tsteur commented Jan 31, 2016

Thx for the report! I'm seeing this as a bug as well. When someone is using the mobile app, it should be marked as logged in as well.

It's possibly easy to fix my removing the check for API calls here: https://github.com/piwik/piwik/blob/2.16.0-rc1/plugins/UsersManager/LastSeenTimeLogger.php#L41-L46

Any API call equals to a log in or last seen. I can only presume API requests were ignored so far for performance reasons so we probably need some kind of "cache" maybe to make it fast for API calls

@xymantec
Copy link
Author

xymantec commented Feb 1, 2016

Hi tsteur,
I can confirm this fix works, I removed lined 41-46 and the last seen functionality worked once again.

@xymantec xymantec closed this as completed Feb 2, 2016
@tsteur
Copy link
Member

tsteur commented Feb 2, 2016

I'll reopen it as we should fix it here as well. Otherwise, next time you update, it won't work again.

@tsteur tsteur reopened this Feb 2, 2016
@xymantec
Copy link
Author

xymantec commented Feb 2, 2016

lmao sorry about that, I wasn't sure if I should close it or not.

@tsteur
Copy link
Member

tsteur commented Feb 2, 2016

No worries. Thx for creating the issue! Feel free to create another issue any time you experience other problems or have ideas to improve Piwik

@mattab mattab modified the milestones: Mid term, 3.0.0 Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Data Integrity & Accuracy
Projects
None yet
Development

No branches or pull requests

3 participants