New sentence after a successful Piwik installation #9655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k installation
tsteur
added
not-in-changelog
|
Note to self
|
tsteur
added a commit
that referenced
this pull request
Jan 31, 2016
New sentence presenting Piwik PRO after a successful Piwik installation
|
New FAQ How do I remove from Piwik the links to "Professional Services"? and added link in the blog post + FAQ. |
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9648
[General]piwik_pro_ads_enabledto enable/disable it.I was thinking about putting this logic into plugin but then it might get hard re the twig filters which are defined in core. We cannot access anything in core that is defined in a plugin. We could technically but it is not good.
The new class
Advertisingwill be public API as eg PiwikPRO plugins will need to check whether they can add a top menu link or not.Be good to have this merged soon as it will be a foundation for other issues that I will be working on in a bit.