New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use CSS sprites #965
Comments
CSS sprites would be very useful for country flags too. Ideally, a script would be run that would take the list of input images, and build the merged version, as well as build the map in a php array of the X/Y offsets of the sprite. I have heard of open source library to do this already, for example: http://csssprites.org/. This one seems to be the best practise to use: reference the logos in the CSS file, and the tool parses the CSS and builds the sprite version. |
when adding this feature, there should be a quick README explaining: How to add a new logo for a flag, or a new browser? Setup the css, run the script to convert the css, etc. |
CSS sprites, if added as a feature, should not add overhead to the developper's time of building new UI or adding new logos in the Piwik release. vipsoft, what are your thoughts about this new feature and its implementation? |
Using sprites isn't all or nothing. I recommend that we only use sprites where:
Proposal:
|
Probably too tricky with the new Theming feature |
+1 CSS sprites in the following plugins would significantly increase (perceived) loading and display time of the Dashboard: As of today the Dashboard flickers and quivers for quite a few seconds, mainly when displaying the visitors panel, until all images are loaded. |
Reason: reducing the number of http connections may result in pages loading faster.
Proposed icon sets for conversion:
Note: there are a mix of icon sizes in plugins/UsersSettings, mostly 14x14 and 16x16 with a few odd ones:
For consistency, these should be resized (refreshed from full size images, if possible) to 16x16 for consistency.
The text was updated successfully, but these errors were encountered: