Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to fix UI test #9644

Closed
wants to merge 2 commits into from
Closed

Attempting to fix UI test #9644

wants to merge 2 commits into from

Conversation

mattab
Copy link
Member

@mattab mattab commented Jan 27, 2016

Failing build: https://travis-ci.org/piwik/piwik/jobs/105077424

Example UI screenshot fail: http://builds-artifacts.piwik.org/piwik/piwik/master/17793/ActionsDataTable_subtables_loaded

UI tests started to fail, and after investigating I'm left confused. The footer control bar is now closed on the "processed" screenshots while it should be opened. I can't find any reason why the footer controls would now be closed. Trying here to open them specifically in the test where they now appear closed.

Follows UP: #9618

Failing build: https://travis-ci.org/piwik/piwik/jobs/105077424

Example UI screenshot fail: http://builds-artifacts.piwik.org/piwik/piwik/master/17793/ActionsDataTable_subtables_loaded

UI tests started to fail, and after investigating I'm left confused. The footer control bar is now closed on the "processed" screenshots while it should be opened. I can't find any reason why the footer controls would now be closed. Trying here to open them specifically in the test where they now appear closed.

Follows UP: #9618
@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jan 27, 2016
@mattab mattab added this to the 2.16.0 milestone Jan 27, 2016
@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jan 27, 2016
@mattab
Copy link
Member Author

mattab commented Feb 1, 2016

Will fix it in master directly

@mattab mattab closed this Feb 1, 2016
@mattab mattab deleted the ui_test_fixtest branch March 15, 2016 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant