Display a footer message below Custom Variables report which explains why some metrics are not set #9643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are not set Goal: minimise user confusion and support requests. The message is only displayed when the report table contains Custom Variable of scope 'page'. If the report only contains Custom Variable of scope 'visit' the message won't be shown. Fixes #8128
mattab
added
not-in-changelog
| Piwik::translate('General_And'), | ||
| Piwik::translate('General_ColumnNbUsers') | ||
| ); | ||
| $messageStart = Piwik::translate('Note: %s metrics are available for Custom Variables of scope \'visit\' only.', $metrics); |
There was a problem hiding this comment.
Shouldn't a translation key be specified?
|
Thanks, feedback is applied @tsteur |
mattab
pushed a commit
that referenced
this pull request
Jan 27, 2016
Display a footer message below Custom Variables report which explains why some metrics are not set
| @@ -34,5 +35,40 @@ public function configureView(ViewDataTable $view) | |||
| $view->config->addTranslation('label', Piwik::translate('CustomVariables_ColumnCustomVariableName')); | |||
| $view->requestConfig->filter_sort_column = 'nb_actions'; | |||
| $view->requestConfig->filter_sort_order = 'desc'; | |||
|
|
|||
| $view->config->filters[] = function (DataTable $table) use ($view) { | |||
| if($this->isReportContainsUnsetVisitsColumns($table)) { | |||
There was a problem hiding this comment.
This fails on PHP 5.3 see eg http://builds-artifacts.piwik.org/piwik/piwik/9649/17844/PivotByDimension_pivoted_columns_report . Instead we need to use use ($view, $self)
There was a problem hiding this comment.
Just noticed it was already fixed in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: minimise user confusion and support requests.
The message is only displayed when the report table contains Custom Variable of scope 'page'.
If the report only contains Custom Variable of scope 'visit' the message won't be shown.
Fixes #8128