Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some characters in Email subject and Email attachments filename #9632

Merged
merged 2 commits into from Jan 27, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Jan 26, 2016

Fixes #9631 #9580

@mattab mattab added the Needs Review PRs that need a code review label Jan 26, 2016
@mattab mattab modified the milestone: 2.16.1 Jan 26, 2016
* @param $string
* @return mixed
*/
static public function sanitiseString($string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed to have this method static?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the useless static

mattab pushed a commit that referenced this pull request Jan 27, 2016
Replace some characters in Email subject and Email attachments filename
@mattab mattab merged commit ece5578 into master Jan 27, 2016
@mattab mattab deleted the 9631 branch January 27, 2016 00:07
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 30, 2016
@mattab mattab modified the milestones: 2.16.x, 2.16.1, 2.16.0 Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants