Heartbeat / ping requests should only update visit_total_time #9626
Labels
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
This is going to be a bit technical: So far, when a ping request is sent, the request processor unsets other actions to prevent them from being created here: https://github.com/piwik/piwik/blob/2.16.0-b6/plugins/Heartbeat/Tracker/PingRequestProcessor.php#L24-L29
However, the visit itself is still updated. This has many downsides and risks:
PingRequestProcessor
unsets anAction
metadata so no entry inlog_link_visit_action
gets created. It does this also for some Goals metadata etc. However if we change somewhere something in the code and forget to update the ping processor, we will introduce new bugs. This might be already the case for any 3rd party plugins including the ones from Piwik PRO.&idSite=5&ping=1
(There's a chance it works already like this right now)In general, the ping request processor should simply update
visit_total_time
and that's it. The ping request processor will only cause no bugs and side effects if it has no knowledge of any other plugins. With the current implementation, it has to know everything about all dimensions. This makes it a problem for Piwik PRO and 3rd party plugins but also when we change or add code.The text was updated successfully, but these errors were encountered: