Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reports for period have invalid filename #9580

Closed
bwagenseil opened this issue Jan 20, 2016 · 5 comments
Closed

reports for period have invalid filename #9580

bwagenseil opened this issue Jan 20, 2016 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@bwagenseil
Copy link

The Filename of the attached report file for a report over a period (weekly, monthly, etc) contains a invalid character (en dash / u+2013), which causes some mail clients aren't able to open the mail / attachment.

The filename must built following the rules of the RFC 5987 to allow characters which aren't in ASCII or ISO-8859-1.

Be aware that the filename is identical to the subject of the mail plus the file extension. I did a quick fix changing all en dashes in ./plugins/Intl/lang/de.json (for my use only in german) into dash inside of ASCII code table.
@tsteur
Copy link
Member

tsteur commented Jan 20, 2016

Do you mean the attachments in sent emails via a scheduled report contain invalid characters?

@bwagenseil
Copy link
Author

No, the attachments themselves are fine. I mean the filename of the attachment in the header of the mime body. See following part of source code of a email:

--=_7d9a4ed223249f0d3dfea17c59cb11cc
Content-Type: application/pdf
Content-Transfer-Encoding: base64
Content-Disposition: inline; filename="Bericht XXXX - Woche 4.–10. Januar 2016.pdf"

@tsteur tsteur mentioned this issue Jan 26, 2016
Closed
@mattab mattab mentioned this issue Jan 26, 2016
Merged
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 26, 2016
@mattab
Copy link
Member

mattab commented Jan 26, 2016

@bwagenseil could you try to apply this patch: https://patch-diff.githubusercontent.com/raw/piwik/piwik/pull/9632.patch (you only need to patch the changes to core/Mail.php) and see if it fixes the issue? if it does not fix the issue please let us know as fast as possible so we may have a chance to fix it in 2.16.0 due in next few days

@bwagenseil
Copy link
Author

Many thanks for the quick fix and the patch works fine so far.

@mattab
Copy link
Member

mattab commented Jan 27, 2016

That's great news @bwagenseil thanks for letting us know

@mattab mattab closed this as completed Jan 30, 2016
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Jan 30, 2016
@Geal Geal mentioned this issue Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsteur @mattab @bwagenseil