Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add border to outline currently focused element, when using app with keyboard #9578

Closed
mattab opened this issue Jan 20, 2016 · 2 comments
Closed

Add border to outline currently focused element, when using app with keyboard #9578

mattab opened this issue Jan 20, 2016 · 2 comments
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.16.0

Comments

@mattab
Copy link
Member

mattab commented Jan 20, 2016

  • Got: in Firefox, there is no outline around the currently focused element, when the element is within the page, for example on a H2 title.
  • Expected: similarly as with Google Chrome, Firefox should show an outline for focused elements is clearly visible with a grey border:
    focused

Maybe we could overwrite the default outline style and make it a clearly visible border such as is done in Google Chrome on the screenshot above?
@mattab mattab added the c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). label Jan 20, 2016
@nstallinger nstallinger mentioned this issue Jan 21, 2016
Merged
@mattab
Copy link
Member Author

mattab commented Jan 21, 2016

fixed in #9600

@mattab mattab closed this as completed Jan 21, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 21, 2016
@mattab mattab added this to the 2.16.0 milestone Jan 21, 2016
@mattab mattab mentioned this issue Jan 21, 2016
Merged
@mattab
Copy link
Member Author

mattab commented Jan 21, 2016

Problem is: sometimes when using the mouse, the outline is displayed, causing the design to look rather bad. Expected: outline should only show when the keyboard is used.

@mattab mattab reopened this Jan 21, 2016
@mattab mattab removed this from the 2.16.0 milestone Jan 21, 2016
@mattab mattab removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 21, 2016
@mattab mattab closed this as completed Mar 31, 2016
@mattab mattab added this to the 2.16.0 milestone Mar 31, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
1 participant
@mattab