Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: make currently selected menu item colors themable #9573

Merged
merged 2 commits into from Jan 20, 2016
Merged

Themes: make currently selected menu item colors themable #9573

merged 2 commits into from Jan 20, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 20, 2016

This new variable is needed as the menu is otherwise not really themable when using a dark background color.

You can reproduce this by specifying a theme with

@theme-color-menu-contrast-text: white;
@theme-color-menu-contrast-textActive: gray;
@theme-color-menu-contrast-background: black;

it can be now fixed by specifying on top

@theme-color-menu-contrast-textSelected: darkgrey;

It was not needed with current theme as both the background color and the menu background color is pretty light. However it does not work with a light background color but dark menu background color.

@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Jan 20, 2016
@tsteur tsteur added this to the 2.16.0 milestone Jan 20, 2016
tsteur added a commit that referenced this pull request Jan 20, 2016
@tsteur
Merge pull request #9573 from piwik/themable_menu_item
13800af 
Themable text color of the currently selected menu item
@tsteur tsteur merged commit 13800af into master Jan 20, 2016
@tsteur tsteur deleted the themable_menu_item branch January 20, 2016 02:18
@mattab mattab changed the title Themable text color of the currently selected menu item Themes: make currently selected menu item themable Jan 30, 2016
@mattab mattab changed the title Themes: make currently selected menu item themable Themes: make currently selected menu item colors themable Jan 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tsteur