Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refs #9419 always set character set latin1 #9520

Merged
merged 1 commit into from Jan 14, 2016
Merged

refs #9419 always set character set latin1 #9520

merged 1 commit into from Jan 14, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 14, 2016

In #6497 we set the charset in the config to utf8 by default. This caused that latin1 was not set anymore and causes failures on MySQL 5.7. By forcing charset latin1 the load data infile of archives works again.

@tsteur
refs #9419 always set character set latin1
e869e7e 
In #6497 we set the charset in the config to utf8 by default. This caused that latin1 was not set anymore and causes failures on MySQL 5.7. By forcing charset latin1 the load data infile of archives works again.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 14, 2016
@tsteur tsteur added this to the 2.16.0 milestone Jan 14, 2016
mattab pushed a commit that referenced this pull request Jan 14, 2016
Merge pull request #9520 from piwik/9419
96d1132 
refs #9419 always set character set latin1
@mattab mattab merged commit 96d1132 into master Jan 14, 2016
@mattab mattab deleted the 9419 branch January 14, 2016 06:13
@mattab
Copy link
Member

mattab commented Jan 14, 2016

after merging I noticed that there is actually one test failing:

1) Piwik\Tests\Integration\ArchiveProcessingTest::testTableInsertBatch
Record 4 bug, not 简体中文 BUT 简体中文
Failed asserting that two strings are equal.

--- Expected
+++ Actual
@@ @@
-'简体中文'
+'简体中文'

ping @tsteur

@tsteur
Copy link
Member Author

tsteur commented Jan 14, 2016

FYI: The test seems to work fine with MySQL 5.7 and it fails when $fileSpec['charset'] = 'latin1' is missing. So exactly the other way around

@tsteur tsteur mentioned this pull request Jan 15, 2016
Merged
@mattab mattab mentioned this pull request Jan 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab