Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test data #9519

Merged
merged 1 commit into from Jan 14, 2016
Merged

Improve test data #9519

merged 1 commit into from Jan 14, 2016

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 13, 2016

As suggested in https://github.com/piwik/piwik/pull/9478/files#r49521757 I've improved the test data by using various useragents.

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 13, 2016
@@ -1,4 +1,9 @@
<?xml version="1.0" encoding="utf-8" ?>
<result>
<row>Unknown</row>
<row>HTC</row>
<row>Samsung</row>
<row>Google</row>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

mattab pushed a commit that referenced this pull request Jan 14, 2016
@mattab mattab merged commit 598f3f6 into master Jan 14, 2016
@mattab mattab added this to the 2.16.0 milestone Jan 14, 2016
@sgiehl sgiehl deleted the improvetests branch January 17, 2016 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants