Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translations #9517

Closed

Conversation

gboddin
Copy link

@gboddin gboddin commented Jan 13, 2016

Previous error message seems to cause confusion amongst users when running in archiving mode.

Suggesting some clarification

@tsteur
Copy link
Member

tsteur commented Jan 13, 2016

Ideally we would check whether we have actually processed it or whether is really no data which might be possible but it is complicated. See #404 .

@mattab what do you think about this message meanwhile?

@tsteur tsteur added the Needs Review PRs that need a code review label Jan 13, 2016
@tsteur
Copy link
Member

tsteur commented Jan 13, 2016

Thx for the PR btw. I just realized it's only a translation string which has to be changed via https://www.transifex.com/piwik/piwik/ . We cannot change translations via PRs unfortunately. I'll close it for now but feel free to sign up on transifex via your github account and to suggest the change there

@tsteur tsteur closed this Jan 13, 2016
@tsteur tsteur added answered For when a question was asked and we referred to forum or answered it. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jan 13, 2016
@tsteur tsteur added this to the 2.16.0 milestone Jan 13, 2016
@tsteur tsteur self-assigned this Jan 13, 2016
@sgiehl
Copy link
Member

sgiehl commented Jan 13, 2016

@tsteur Thats not correct. English translations needs to be updated in the code, as transifex pulls them from github. So this change might be valid.

@tsteur
Copy link
Member

tsteur commented Jan 13, 2016

True, so it would invalidate all the others to make sure they get translated as well. Thx!

Reopening

@tsteur tsteur reopened this Jan 13, 2016
@mattab
Copy link
Member

mattab commented Jan 14, 2016

Hi @gboddin
Transitions data is not processed or archived, but it is generated in real time. Therefore message should be correct.

@mattab mattab closed this Jan 14, 2016
@gboddin
Copy link
Author

gboddin commented Jan 14, 2016

@Mattlab

Not sure I get your point, but I'll explain the situtation that led to this PR :

We're running a pretty medium instance of Piwik (~7M hits per months), and as you know an archiving can take some times.

When a (offline-archived) segment is edited, its data can be invalidated for some time (till the next archive process), which then display the mentionned message.

That's why we got one of our user asking if it could mention that data could actually come up ... soonish instead of saying there's no data at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants