Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For a Piwik PRO developer always specify a max version for a plugin by default #9511

Closed
wants to merge 2 commits into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 12, 2016

refs #8695

This is to be defined whether it's actually needed / wanted by Piwik PRO developers.

Piwik PRO developers would enable Piwik PRO mode initially with

./console development:enable --piwikpro

Following development:enable commands would not need this flag as we wouldn't change it afterwards anymore. It would be otherwise forgotton and annoying to always having to add this flag.

When this mode is enabled, and a plugin is generated, we automatically specify a maximum supported Piwik version in plugin.json. Instead of

    "require": {
        "piwik": ">=2.15.0-rc1"
    },

we specify

    "require": {
        "piwik": ">=2.15.0-rc1,<=2.15.0-rc1"
    },

for Piwik PRO developers. From my understanding in #8695 this is what Piwik PRO developers want. So far it was specified in .travis.yml. Please note that when a max version is specified, it cannot be installed on a later Piwik version. This is something that needs to be configured.

Also see related PR matomo-org/travis-scripts#21

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 12, 2016
@tsteur tsteur added this to the 2.16.0 milestone Jan 12, 2016
@mattab mattab modified the milestones: 2.16.0, 2.16.1 Jan 18, 2016
@hpvd
Copy link

hpvd commented Feb 2, 2016

Please note that when a max version is specified, it cannot be installed on a later Piwik version. This is something that needs to be configured.

don't know excactly if it's really the same technical background, but in FF you have in the past the problem that some addons doesn't work beacuse they were marked as "non compatible".Changing the supported version in the addon code solved this.This was pretty annoying.

hmm setting this: where from should one know that a plugin would work in special future version?
maybe it's a ready not working with the version before the set version...

@tsteur
Copy link
Member Author

tsteur commented Feb 2, 2016

Yeah setting the max version is not really a good solution as it would kinda mean we fail as being a platform as we break API's randomly. However, from what I understood, this is the workflow for Piwik Pro developers. There are automated processes that run a plugin against a new Piwik version when it's about to be released and the max version gets automatically updated in case the tests are still green.

@tsteur
Copy link
Member Author

tsteur commented Feb 2, 2016

FYI: This flag is only meant for Piwik PRO developers

@tsteur tsteur changed the title For a piwik pro developer always specify a max version for a plugin by default For a Piwik PRO developer always specify a max version for a plugin by default Feb 2, 2016
@mattab
Copy link
Member

mattab commented Jun 15, 2016

as this is not be needed now, closing.

@mattab mattab closed this Jun 15, 2016
@mattab mattab deleted the 8695 branch June 21, 2017 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants