@tzi opened this Pull Request on August 7th 2013 Member

Hi.

I continue to code on the stylesheets of the Piwik solution.
In this PR, you will find:

1- Fix regressions:

  • Website selector pushes content down instead of on hover
  • The language selector pushes content on click
  • The language selector right arrow is too large
  • Add display of site selector in "Email & SMS Reports"
  • The menu should go back to the "Currently selected" menu on focus after abt couple seconds
  • In the calendar, bug: clicking on the Month Previous/next button closes the calendar

2- Some refactoring of existing code, like dataTable stylesheets

3- Theme of new elements for the PleineLune:

  • Sata tables
  • Site selector
  • Period selector
  • Segment selector
  • Widget selector
  • About piwik box
  • Popin UI
  • jQplot graph
  • Sparkline graphs
  • Transitions

Cheers,
Thomas.

@mattab commented on August 8th 2013 Member

Wow looks beautiful!
I'd love to merge but can't merge automatically, could you update?

@tzi commented on August 8th 2013 Member

Thanks!
I hope you'll appreciate it.
It should be mergable now :)

@mattab commented on August 8th 2013 Member

Nice progress, PleineLune is taking shape big time! I like the centred menu, and the changes you made such as putting site selector on level of menu. Nice that Transitions is themable.

[ updated Aug 10th ]

Review of Theme PleineLune:

  • General Elements
    • Calendar is not themed
    • Metrics picker above graph not themed
    • Annotations>Edit one. Save + Cancel buttons not themed. (buttons also used in Admin, Email reports, etc)
    • 'Widgets' page: the INPUT fields are not themed
    • Tooltip not themed (eg. Visitors>Visitor Log> Hover on one Action)
    • on Visitors>Overview. Click on the Title. It shows the report documentation which is not themed.
  • Data tables:
    • on Row Evolution report, below the sparkline is a grey line. Instead there should be no grey line.
    • Referrers>Overview. In the table of reports on the left, The list of reports appear on white backgrounds.
    • on Hover on a datatable Column name, the Tooltip with documentation is not themed
    • when expanding a subtable (in Actions>Pages eg.) there is a white border-bottom left below the subtable
  • Real time widget: list of visitors not themed
  • Visitor>Custom Variables.
    • Click on a custom variable. The subtable loads. This table has alternate styles. The dark grey font color has not enough contrast.
    • On Datatable hover, the whole rows become color light grey. Instead on hover it should only color the currently hovered subtable's row.
  • All Websites
    • first column looks OK but other columns have white border around cells
    • sort icons are not visible in the table header
  • Admin
    • H3 style is not themed(eg in Admin>DB Usage)
    • yellow tooltips are not themed (eg. in Geolocation)
  • Login form not fully themed
  • Popover: eg. when changing dashboard layout, the Popover footer is white background but should be same as popover content background
    • Visitor Log: when a visitor has converted to a Goal, the "Action" column is displayed in Yellow. It could be themed with darker color.
@diosmosis commented on August 8th 2013 Member

Regarding the last regression: If it occurs on master and only if there's no data for the evolution graph, it's a regression caused by my earlier commits. I'll be fixing it soon. It also shows up when changing to a sparkline where the metric has no data.

@mattab commented on August 8th 2013 Member

More from Benaka & I testing:

  • Dashboard is partly broken, we can't move widgets anymore. ie. Change layout to 4 columns: then we can't move widgets. Can you revert your changes to dashboard?
  • We lost the Tooltips for all graphs (on hover there is no tooltip anymore)
@mattab commented on August 9th 2013 Member
  • the down arrow is missing in Segment Editor grey box / Widgets & Dashboard boxes

PS: i fixed the PleineLune Activate link

@tzi commented on August 9th 2013 Member

Thanks for the feedbacks Matt!

For now, I fixed:
[X] Segment Editor > click on "edit" a segment: the selector is hidden
[X] Menu > Enable the ExampleUI plugin. Then the Menu does not fit on one line. To solve this, the Site Selector should be less wide/smaller font.
[X] Site Selector > it pushes content down. Instead the site selector should appear on top of the content.
[X] On Manage > Websites, I cannot scroll to the right. There is no scroll bar.
[X] The down arrow is missing in Segment Editor grey box / Widgets & Dashboard boxes

I continue by looking for these bugfixes:
[ ] All Websites > sort icons are not visible in the table header
[ ] Sparklines not working on Zeitgeist
[ ] Sparklines point not working on PleinLune
[ ] On Goals > Overview or Referers>Overview, click on a sparkline. It does not reload the graph and shows the message: The parameter 'columns' isn't set in the Request, and a default value wasn't provided.
[ ] jQplot > We lost the Tooltips for all graphs (on hover there is no tooltip anymore)

The other bugs are either for the theme or those sent to Stefan.

@diosmosis commented on August 9th 2013 Member

Note: I just committed some fixes for regressions, so some on your list may be fixed on master.

@tzi commented on August 9th 2013 Member

I sent a new PR for these bugfixes : https://github.com/piwik/piwik/pull/99

@mattab commented on August 9th 2013 Member

Thanks, much better now!!

@mattab commented on August 10th 2013 Member

Remaining regressions:

  • SegmentEditor
    • missing the "Add new segment" button in Zeitgeist (when there are 10 custom segments)
    • when editing a segment, the text overlaps with icon. Also there is some remaining pixels on the top left.
    • in PleineLune, when creating a segment, the panel is hidden (but it works in zeitgeist when editing segment)
  • Graph tooltips are missing
  • Missing scrollbar on Settings>Websites
  • All Websites > sort icons are not visible in the table header
  • Site selector missing on API + Widgets pages
@mattab commented on August 10th 2013 Member

I updated the list at: https://github.com/piwik/piwik/pull/95#issuecomment-22333615 to keep only open issues

This Pull Request was closed on August 8th 2013
Powered by GitHub Issue Mirror