New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PleineLune theming #95
Conversation
…le seconds off focus
Wow looks beautiful! |
Thanks! |
PleineLune theming: Refactoring, Fix Regressions + All UI elements now Themable
Nice progress, PleineLune is taking shape big time! I like the centred menu, and the changes you made such as putting site selector on level of menu. Nice that Transitions is themable. [ updated Aug 10th ] Review of Theme PleineLune:
|
Regarding the last regression: If it occurs on master and only if there's no data for the evolution graph, it's a regression caused by my earlier commits. I'll be fixing it soon. It also shows up when changing to a sparkline where the metric has no data. |
More from Benaka & I testing:
|
PS: i fixed the PleineLune Activate link |
Thanks for the feedbacks Matt! For now, I fixed: I continue by looking for these bugfixes: The other bugs are either for the theme or those sent to Stefan. |
Note: I just committed some fixes for regressions, so some on your list may be fixed on master. |
I sent a new PR for these bugfixes : #99 |
Thanks, much better now!! |
Remaining regressions:
|
I updated the list at: #95 (comment) to keep only open issues |
Hi.
I continue to code on the stylesheets of the Piwik solution.
In this PR, you will find:
1- Fix regressions:
2- Some refactoring of existing code, like dataTable stylesheets
3- Theme of new elements for the PleineLune:
Cheers,
Thomas.