I continue to code on the stylesheets of the Piwik solution.
In this PR, you will find:
1- Fix regressions:
2- Some refactoring of existing code, like dataTable stylesheets
3- Theme of new elements for the PleineLune:
Wow looks beautiful!
I'd love to merge but can't merge automatically, could you update?
I hope you'll appreciate it.
It should be mergable now :)
Nice progress, PleineLune is taking shape big time! I like the centred menu, and the changes you made such as putting site selector on level of menu. Nice that Transitions is themable.
[ updated Aug 10th ]
Review of Theme PleineLune:
Regarding the last regression: If it occurs on master and only if there's no data for the evolution graph, it's a regression caused by my earlier commits. I'll be fixing it soon. It also shows up when changing to a sparkline where the metric has no data.
More from Benaka & I testing:
PS: i fixed the PleineLune Activate link
Thanks for the feedbacks Matt!
For now, I fixed:
[X] Segment Editor > click on "edit" a segment: the selector is hidden
[X] Menu > Enable the ExampleUI plugin. Then the Menu does not fit on one line. To solve this, the Site Selector should be less wide/smaller font.
[X] Site Selector > it pushes content down. Instead the site selector should appear on top of the content.
[X] On Manage > Websites, I cannot scroll to the right. There is no scroll bar.
[X] The down arrow is missing in Segment Editor grey box / Widgets & Dashboard boxes
I continue by looking for these bugfixes:
[ ] All Websites > sort icons are not visible in the table header
[ ] Sparklines not working on Zeitgeist
[ ] Sparklines point not working on PleinLune
[ ] On Goals > Overview or Referers>Overview, click on a sparkline. It does not reload the graph and shows the message: The parameter 'columns' isn't set in the Request, and a default value wasn't provided.
[ ] jQplot > We lost the Tooltips for all graphs (on hover there is no tooltip anymore)
The other bugs are either for the theme or those sent to Stefan.
Note: I just committed some fixes for regressions, so some on your list may be fixed on master.
I sent a new PR for these bugfixes : https://github.com/piwik/piwik/pull/99
Thanks, much better now!!
I updated the list at: https://github.com/piwik/piwik/pull/95#issuecomment-22333615 to keep only open issues